I like ball markers since they don’t take up much space. I’ll usually pick up one at any course I play. Started getting Tervis tumblers a few years ago too but typically only get those if I think the course/tournament logo looks cool. As others have mentioned, space and utility have come into play in the past few years for purchasing decisions.
Also like to have a yardage book when playing a course so I’ll often get those and putting those on display just screams “businessman” so of course I have those out at the office. And since getting more into course architecture thanks to @thefriedegg and the podcasts with Tom Doak, they’re fun to leaf through.